Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand ModManager, add System Editor prerequisites #5623

Merged
merged 7 commits into from
Sep 8, 2023
Merged

Expand ModManager, add System Editor prerequisites #5623

merged 7 commits into from
Sep 8, 2023

Conversation

sturnclaw
Copy link
Member

Catchall PR with useful commits not directly related to the System Editor coming out of that branch.

In brief:

  • Cleanup Background::StarField so it actually does what it says on the tin.
  • Expand ModManager functionality to allow querying and disabling mods.
  • Added Portable File Dialogs for editor usage, has a very nice API to wrap what is otherwise a horrible platform-specific mess.
  • Migrate autoload.lua into the "minimal" Lua state configuration (for LuaNameGen and other lightweight Lua utilities to run outside of the main Lua state).
  • Replace (most of) our various string-splitting helper functions with a generic interface to iterate string fragments and collate them into a vector-like container.
    • There are several hand-written re-implementations of the same functionality scattered around the code that I have not tracked down and replaced with the SplitString utility. A task for another PR.

@sturnclaw
Background: don't automatically Fill the starfield
f24751c 
This allows using the Background::Container in non-Game contexts
@sturnclaw
ModManager: allow disabling mods
34270f6 
- Mods are not loaded if there is a key in the configuration file specifying the mod as disabled.
- Provide an interface to enumerate loaded mods, get their file paths, and access their filesystem
@sturnclaw
SystemView: separate viewed / selected API
c6724dd 
- Optionally display and allow centering on object gravpoints.
- Decouple the selected object from the viewed object and allow setting both independently.

SystemView: handle drawing without system ptr
@sturnclaw
EditorApp: make sure to initialize Lang
9f08c05
@sturnclaw
Add Portable File Dialogs library
6dbdfd6 
Licensed under WTFPLv2, selected to implement editor file-picker interface.
@sturnclaw
Load autoload.lua in "minimal" lua states
a746eb7
@sturnclaw
New for-loop based SplitString utility
6775451 
- Splits arbitrary input string_view based on delimiter characters
- Replaces old SplitSpec/SplitString functionalities
- General-purpose high-reliability string processing utility
@sturnclaw sturnclaw mentioned this pull request Sep 8, 2023
Merged
@fluffyfreak fluffyfreak self-requested a review September 8, 2023 13:22
fluffyfreak
fluffyfreak approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@fluffyfreak fluffyfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, especially of the background cleanup, but it's all good work!

@sturnclaw sturnclaw merged commit 9f8944e into pioneerspacesim:master Sep 8, 2023
4 of 5 checks passed
@sturnclaw sturnclaw deleted the editor-prerequisite branch September 9, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluffyfreak fluffyfreak fluffyfreak approved these changes

Assignees
No one assigned
Labels
C++ code Cleanup New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sturnclaw @fluffyfreak